-
Notifications
You must be signed in to change notification settings - Fork 12
Added GPS FeatherWing #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, I have tested this on the Feather M4 Express and the Feather nRF52840 Express. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One minor cosmetic suggestion.
|
||
def update(self): | ||
""" | ||
Make sure to call gps.update() every loop iteration and at least twice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wan it to show up as code in the docs, you can put double backticks on either side (``). Single backticks will cause sphinx to attempt to do something with it, double tells sphinx that you're trying to display something in fixed-width font.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm referring to gps.update()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn't know that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks!
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#3 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#31 from jerryneedell/jerryn_gps > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#29 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#28 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_PyPortal
Ok, here's the GPS FeatherWing code. It handles the initialization automatically, makes some properties shorter names and has some speed calculations such as providing the speed in MPH and KPH.